Re: [PATCH v3 1/2] watchdog: Add driver for Intel OC WDT

From: Diogo Ivo
Date: Tue Apr 08 2025 - 04:33:08 EST


Hello,

On 3/17/25 10:55 AM, Diogo Ivo wrote:
Add a driver for the Intel Over-Clocking Watchdog found in Intel
Platform Controller (PCH) chipsets. This watchdog is controlled
via a simple single-register interface and would otherwise be
standard except for the presence of a LOCK bit that can only be
set once per power cycle, needing extra handling around it.

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Diogo Ivo <diogo.ivo@xxxxxxxxxxx>
---
v2->v3:
- Collect R-b from Guenter

v1->v2:
- Split v1 into two patches, adding the ACPI IDs in a separate patch
- Initialize hearbeat module parameter to zero
- Clarify wording around lock handling
- Properly print resource with %pR when failing to obtain it
- Enable compile testing and add dependency on HAS_IOPORT
- Drop unneeded ACPI_PTR() and MODULE_ALIAS()
---
---
drivers/watchdog/Kconfig | 11 ++
drivers/watchdog/Makefile | 1 +
drivers/watchdog/intel_oc_wdt.c | 233 ++++++++++++++++++++++++++++++++++++++++
3 files changed, 245 insertions(+)


Gentle ping on this patch.

Best regards,
Diogo