Re: [PATCH v3 2/2] erofs: add 'offset' mount option for file-backed & bdev-based mounts

[Gao Xiang]

On 2025/4/8 16:46, Karel Zak wrote:
> On Mon, Apr 07, 2025 at 11:49:31PM +0800, Gao Xiang wrote:
> > On 2025/4/7 19:40, Karel Zak wrote:
> > > We can improve it in libmount and add any if-erofs hack there, but my
> > > suggestion is to select a better name for the mount option. For
> > > example, erofsoff=, erostart=, fsoffset=, start=, or similar.
> >
> > Thanks for your suggestion!
> >
> > it's somewhat weird to use erofsprefix here, I think fsoffset
> > may be fine.
>
> Yes, fsoffset sounds good. I anticipate more filesystems will support
> file-backed mounts in the future, making this option reusable.

From my own kernel perspective, it's not possible for the majority
of read-write fses especially have nested transaction (like
`current->journal_info`) in addition to many deadlock factors
without extra workqueue contexts.  But for erofs it's safe.

Thanks,
Gao Xiang