Re: [PATCH RESEND] arm64: dts: qcom: apq8016-sbc-d3-camera: Convert to DT overlay
From: Dmitry Baryshkov
Date: Tue Apr 08 2025 - 07:59:14 EST
On Tue, Apr 08, 2025 at 01:38:42PM +0200, Stephan Gerhold wrote:
> From: Stephan Gerhold <stephan@xxxxxxxxxxx>
>
> Follow the example of the recently added apq8016-sbc-usb-host.dtso and
> convert apq8016-sbc-d3-camera-mezzanine.dts to a DT overlay that can be
> applied on top of the apq8016-sbc.dtb. This makes it more clear that
> this is not a special type of DB410c but just an addon board that can
> be added on top.
>
> Functionally there should not be any difference since
> apq8016-sbc-d3-camera-mezzanine.dtb is still generated as before
> (but now by applying the overlay on top of apq8016-sbc.dtb).
>
> Since dtc does not know that there are default #address/size-cells in
> msm8916.dtsi, repeat those in the overlay to avoid dtc warnings because
> it expects the wrong amount of address/size-cells.
>
> It would be nice to have a generic overlay for the D3 camera mezzanine
> (that can be applied to all 96Boards) but that's much more complicated
> than providing a board-specific DT overlay as intermediate step.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
> This patch was already applied by Bjorn on Sun, 28 Jan 2024 11:45:55 -0600
> as commit ea689ec32bf0d885277d3f58450a85df5149c98b [1]. However, unlike the
> first patch in the series, this one never made it into the repository for
> some reason.
>
> [1]: https://lore.kernel.org/linux-arm-msm/170646395036.64610.14333204830178417809.b4-ty@xxxxxxxxxx/
> ---
> arch/arm64/boot/dts/qcom/Makefile | 5 +++--
> ...ra-mezzanine.dts => apq8016-sbc-d3-camera-mezzanine.dtso} | 12 ++++++++++--
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry