Re: [PATCH v2 3/3] usb: renesas_usbhs: Reorder clock handling and power management in probe

[Lad, Prabhakar]

Hi Shimoda-san,

On Tue, Apr 8, 2025 at 1:37 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
>
> Hello Prabhakar-san,
>
> > From: Yoshihiro Shimoda, Sent: Tuesday, April 8, 2025 7:40 PM
> <snip>
> > > @@ -721,7 +736,7 @@ static int usbhs_probe(struct platform_device *pdev)
> > >             if (ret) {
> > >                     dev_warn(dev, "USB function not selected (GPIO)\n");
> > >                     ret = -ENOTSUPP;
> > > -                   goto probe_end_mod_exit;
> > > +                   goto probe_assert_rest;
>
> nit:
> I think that the label name " probe_assert_reset" or " probe_assert_rst" is better.
>
I'll fix this in v3 to use `probe_assert_reset`.

> Anyway, I think that this patch seems good to me. So,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Also, I tested this patch on my environment (R-Car H3) and it doesn't have any regression.
> So,
>
> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
Thank you for testing.

Cheers,
Prabhakar