Re: Recent changes mean sb_min_blocksize() can now fail

[Darrick J. Wong]

On Tue, Apr 08, 2025 at 06:33:53AM +0100, Phillip Lougher wrote:
> Hi,
> 
> A recent (post 6.14) change to the kernel means sb_min_blocksize() can now fail,
> and any filesystem which doesn't check the result may behave unexpectedly as a
> result.  This change has recently affected Squashfs, and checking the kernel code,
> a number of other filesystems including isofs, gfs2, exfat, fat and xfs do not
> check the result.  This is a courtesy email to warn others of this change.

Thanks for the heads up.  xfs always passes in BBSIZE (aka 512) and
doesn't use the bdev pagecache so I think it's unaffected by failures.

--D

> The following emails give the relevant details.
> 
> https://lore.kernel.org/all/2a13ea1c-08df-4807-83d4-241831b7a2ec@xxxxxxxxxxxxxxx/
> https://lore.kernel.org/all/129d4f39-6922-44e9-8b1c-6455ee564dda@xxxxxxxxxxxxxxx/
> 
> Regards
> 
> Phillip
>