Re: [PATCH 6.13 000/499] 6.13.11-rc1 review

[Ian Rogers]

On Tue, Apr 8, 2025 at 6:09 AM Thorsten Leemhuis <linux@xxxxxxxxxxxxx> wrote:
>
> On 08.04.25 12:43, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.13.11 release.
> > There are 499 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
>
> Compiling for Fedora failed:
>
> util/stat.c: In function ‘evsel__is_alias’:
> util/stat.c:565:16: error: implicit declaration of function ‘perf_pmu__name_no_suffix_match’ [-Wimplicit-function-declaration]
>   565 |         return perf_pmu__name_no_suffix_match(evsel_a->pmu, evsel_b->pmu->name);
>       |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> From a *very very* quick look I wonder if it might be due to this change,
> as it seems to depend on 63e287131cf0c5 ("perf pmu: Rename name matching
> for no suffix or wildcard variants") [v6.15-rc1]:
>
> > Ian Rogers <irogers@xxxxxxxxxx>
> >     perf stat: Don't merge counters purely on name
>
> But as I said, it was just a very very quick look, so I might be totally
> off track there.

Thanks Thorsten, I repeated the failure and reverting that patch fixes
the build. Alternatively, cherry-picking:

```
commit 63e287131cf0c59b026053d6d63fe271604ffa7e
Author: Ian Rogers <irogers@xxxxxxxxxx>
Date:   Fri Jan 31 23:43:18 2025 -0800

   perf pmu: Rename name matching for no suffix or wildcard variants

   Wildcard PMU naming will match a name like pmu_1 to a PMU name like
   pmu_10 but not to a PMU name like pmu_2 as the suffix forms part of
   the match. No suffix matching will match pmu_10 to either pmu_1 or
   pmu_2. Add or rename matching functions on PMU to make it clearer what
   kind of matching is being performed.

   Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
   Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
   Link: https://lore.kernel.org/r/20250201074320.746259-4-irogers@xxxxxxxxxx
   Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
```

Also fixes the build.

Thanks,
Ian

> HTH, Ciao, Thorsten