Re: [PATCH 2/3] rtc: pcf85063: add support for RV8063

[Antoni Pokusinski]

On Tue, Apr 08, 2025 at 08:14:36AM +0200, Krzysztof Kozlowski wrote:
> On 07/04/2025 21:35, Antoni Pokusinski wrote:
> > Microcrystal RV8063 is a real-time clock with SPI interface. Its
> > functionality is very similar to the RV8263 rtc.
> > 
> > Signed-off-by: Antoni Pokusinski <apokusinski01@xxxxxxxxx>
> > ---
> >  drivers/rtc/Kconfig        | 21 ++++++-----
> >  drivers/rtc/rtc-pcf85063.c | 74 +++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 85 insertions(+), 10 deletions(-)
> > 
> > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> > index 838bdc138ffe..1b9be96faa13 100644
> > --- a/drivers/rtc/Kconfig
> > +++ b/drivers/rtc/Kconfig
> > @@ -483,15 +483,6 @@ config RTC_DRV_PCF8523
> >  	  This driver can also be built as a module. If so, the module
> >  	  will be called rtc-pcf8523.
> >  
> > -config RTC_DRV_PCF85063
> > -	tristate "NXP PCF85063"
> > -	select REGMAP_I2C
> > -	help
> > -	  If you say yes here you get support for the PCF85063 RTC chip
> > -
> > -	  This driver can also be built as a module. If so, the module
> > -	  will be called rtc-pcf85063.
> > -
> >  config RTC_DRV_PCF85363
> >  	tristate "NXP PCF85363"
> >  	select REGMAP_I2C
> > @@ -971,6 +962,18 @@ config RTC_DRV_PCF2127
> >  	  This driver can also be built as a module. If so, the module
> >  	  will be called rtc-pcf2127.
> >  
> > +config RTC_DRV_PCF85063
> 
> Why? This breaks the order.
>
I moved this config entry to the "SPI and I2C RTC drivers" section,
because the driver supports now both I2C and SPI devices.

> > +	tristate "NXP PCF85063"
> > +	depends on RTC_I2C_AND_SPI
> > +	select REGMAP_I2C if I2C
> > +	select REGMAP_SPI if SPI_MASTER
> > +	help
> > +	  If you say yes here you get support for the PCF85063 and RV8063
> > +	  RTC chips.
> > +
> > +	  This driver can also be built as a module. If so, the module
> > +	  will be called rtc-pcf85063.
> > +
> 
> 
> ...
> 
> >  module_exit(pcf85063_exit);
> > @@ -740,3 +811,4 @@ module_exit(pcf85063_exit);
> >  MODULE_AUTHOR("Søren Andersen <san@xxxxxxxxxxxxxxxxx>");
> >  MODULE_DESCRIPTION("PCF85063 RTC driver");
> >  MODULE_LICENSE("GPL");
> > +MODULE_ALIAS("spi:rv8063");
> 
> Drop and use proper ID tables.
> 
Will fix that in v2, thanks.
> 
> Best regards,
> Krzysztof

Kind regards,
Antoni