Re: [PATCH v2 03/24] ARM: dts: qcom: msm8916: Use the header with DSI phy clock IDs

[Bjorn Andersson]

On Tue, Apr 08, 2025 at 12:23:18PM +0200, Luca Weiss wrote:
> On Tue Apr 8, 2025 at 11:32 AM CEST, Krzysztof Kozlowski wrote:
> > Use the header with DSI phy clock IDs to make code more readable.
> 
> Hi Krzysztof,
> 
> This patch was the wrong subject, it's touching arm64, not arm32.
> 

Thanks for spotting this, I'll fix it up while applying the patches.

Thanks,
Bjorn

> And thanks for sending this series, it's nice to see some magic numbers
> disappear that make little sense if you don't know what it's about :)
> 
> Regards
> Luca
> 
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8916.dtsi | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > index 8f35c9af18782aa1da7089988692e6588c4b7c5d..c89f9e92e832eae8f630555e9e7f5817d6731d4d 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> > @@ -4,6 +4,7 @@
> >   */
> >  
> >  #include <dt-bindings/arm/coresight-cti-dt.h>
> > +#include <dt-bindings/clock/qcom,dsi-phy-28nm.h>
> >  #include <dt-bindings/clock/qcom,gcc-msm8916.h>
> >  #include <dt-bindings/clock/qcom,rpmcc.h>
> >  #include <dt-bindings/interconnect/qcom,msm8916.h>
> > @@ -1497,8 +1498,8 @@ gcc: clock-controller@1800000 {
> >  			reg = <0x01800000 0x80000>;
> >  			clocks = <&xo_board>,
> >  				 <&sleep_clk>,
> > -				 <&mdss_dsi0_phy 1>,
> > -				 <&mdss_dsi0_phy 0>,
> > +				 <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>,
> > +				 <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
> >  				 <0>,
> >  				 <0>,
> >  				 <0>;
> > @@ -1590,8 +1591,8 @@ mdss_dsi0: dsi@1a98000 {
> >  
> >  				assigned-clocks = <&gcc BYTE0_CLK_SRC>,
> >  						  <&gcc PCLK0_CLK_SRC>;
> > -				assigned-clock-parents = <&mdss_dsi0_phy 0>,
> > -							 <&mdss_dsi0_phy 1>;
> > +				assigned-clock-parents = <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
> > +							 <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>;
> >  
> >  				clocks = <&gcc GCC_MDSS_MDP_CLK>,
> >  					 <&gcc GCC_MDSS_AHB_CLK>,
>