Re: [PATCH] tests/pid_namespace: Add missing sys/mount.h

[T.J. Mercier]

On Tue, Apr 8, 2025 at 3:48 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 4/7/25 16:59, T.J. Mercier wrote:
> > pid_max.c: In function ‘pid_max_cb’:
> > pid_max.c:42:15: error: implicit declaration of function ‘mount’
> >                                         [-Wimplicit-function-declaration]
> >     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
> >        |               ^~~~~
> > pid_max.c:42:36: error: ‘MS_PRIVATE’ undeclared (first use in this
> >                                    function); did you mean ‘MAP_PRIVATE’?
> >     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
> >        |                                    ^~~~~~~~~~
> >        |                                    MAP_PRIVATE
> > pid_max.c:42:49: error: ‘MS_REC’ undeclared (first use in this function)
> >     42 |         ret = mount("", "/", NULL, MS_PRIVATE | MS_REC, 0);
> >        |                                                 ^~~~~~
> > pid_max.c:48:9: error: implicit declaration of function ‘umount2’; did
> >                 you mean ‘SYS_umount2’? [-Wimplicit-function-declaration]
> >     48 |         umount2("/proc", MNT_DETACH);
> >        |         ^~~~~~~
> >        |         SYS_umount2
> > pid_max.c:48:26: error: ‘MNT_DETACH’ undeclared (first use in this
> >                                                                 function)
> >     48 |         umount2("/proc", MNT_DETACH);
> >
> > Fixes: 615ab43b838b ("tests/pid_namespace: add pid_max tests")
> > Signed-off-by: T.J. Mercier <tjmercier@xxxxxxxxxx>
>
> Change the short log to include the subsystem. Send v2 with this
> change.
>
> selftests: pid_namespace: Add missing sys/mount.h
>
> thanks,
> -- Shuah

Done, thanks!
https://lore.kernel.org/all/20250408230204.2775226-1-tjmercier@xxxxxxxxxx/