Re: [PATCH v13 1/3] dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series

[Chen Wang]

On 2025/4/8 7:34, Inochi Amaoto wrote:
> On Mon, Apr 07, 2025 at 07:29:37AM +0200, Alexander Sverdlin wrote:
> > Hi Inochi!
> >
> > On Mon, 2025-04-07 at 09:09 +0800, Inochi Amaoto wrote:
> > > > Add RTC devicetree binding for Sophgo CV1800 series SoC. The device is
> > > > called RTC, but contains control registers of other HW blocks in its
> > > > address space, most notably of Power-on-Reset (PoR) module, DW8051 IP
> > > > (MCU core), accompanying SRAM, hence putting it in SoC subsystem.
> > > I think this is a mfd device, so why not moving this into mfd subsystem?
> > MFD is by far the most tricky subsystem to get into [1] ;-)
> > SOC looks much more realistic [2]
> >
> > [1] https://lore.kernel.org/all/20250306003211.GA8350@xxxxxxxxxx/
> > [2] https://lore.kernel.org/all/20250303-loud-mauve-coyote-1eefbb@krzk-bin/
> Cool, let's keep it.
>
> LGTM.
>
> Reviewed-by: Inochi Amaoto <inochiama@xxxxxxxxx>

Hi, Inochi

I think you were not reviewing the latest version of this patchset. The 
latest version is v14 
@https://lore.kernel.org/linux-rtc/20250315224921.3627852-1-alexander.sverdlin@xxxxxxxxx/

Chen