Re: [PATCH 1/2] dt-bindings: usb: Add binding for PS5511 hub controller

From: Krzysztof Kozlowski
Date: Wed Apr 09 2025 - 02:07:42 EST


On 08/04/2025 06:30, Pin-yen Lin wrote:
>>> + peer-hub:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description:
>>> + phandle to the peer hub on the controller.
>>> +
>>> + ports:
>>> + $ref: /schemas/graph.yaml#/properties/ports
>>
>> I don't understand why do you need OF graph here. Children are already
>> defined in patternProperties as usb-devices.
>
> I would like to describe the connection between the hub and the USB
> connectors, which is similar to commit c44d9dab31d6a9 ("dt-bindings:
> usb: Add downstream facing ports to realtek binding").
>
> I'm aware that Rob expects a usb-hub.yaml binding in [1]. Should I do that now?
Yes, please, two devices using common pattern is already enough to
create common schema.

Best regards,
Krzysztof