Re: [PATCH 02/28] mfd: zl3073x: Register itself as devlink device

[Ivan Vecera]

On 07. 04. 25 10:57 odp., Andrew Lunn wrote:
> On Mon, Apr 07, 2025 at 07:28:29PM +0200, Ivan Vecera wrote:
> > Use devlink_alloc() to alloc zl3073x_dev structure and register
> > the device as a devlink device. Follow-up patches add support for
> > devlink device info reporting and devlink flash interface will
> > be later used for flashing firmware and configuration.
> >
> > Reviewed-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
> > Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
> > ---
> >   drivers/mfd/Kconfig        |  3 +++
> >   drivers/mfd/zl3073x-core.c | 27 +++++++++++++++++++++++++--
> >   2 files changed, 28 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 30b36e3ee8f7f..a838d5dca4579 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -2424,11 +2424,13 @@ config MFD_UPBOARD_FPGA
> >   
> >   config MFD_ZL3073X_CORE
> >   	tristate
> > +	select NET_DEVLINK
> >   	select MFD_CORE
> >   
> >   config MFD_ZL3073X_I2C
> >   	tristate "Microchip Azurite DPLL/PTP/SyncE with I2C"
> >   	depends on I2C
> > +	depends on NET
> >   	select MFD_ZL3073X_CORE
> >   	select REGMAP_I2C
> >   	help
> > @@ -2441,6 +2443,7 @@ config MFD_ZL3073X_I2C
> >   
> >   config MFD_ZL3073X_SPI
> >   	tristate "Microchip Azurite DPLL/PTP/SyncE with SPI"
> > +	depends on NET
>
> It seems odd that the SPI and I2C drivers need net? It is the core
> which is doing devlink stuff.
>
> 	Andrew

Will move this under MFD_ZL3073X_CORE.

Thank you.

I.