Re: [PATCH v8 00/10] Improve gpu_scheduler trace events + UAPI

[Philipp Stanner]

On Wed, 2025-04-09 at 09:52 +0200, Pierre-Eric Pelloux-Prayer wrote:
> Hi,
> 
> I've rebased the series on top of drm-next, applied the minor tweaks
> suggested by Tvrtko on v8 and 
> the R-b tags. The result can be found on gitlab.fdo:
> 
> https://gitlab.freedesktop.org/pepp/linux/-/commits/improve_gpu_scheduler_trace_v9
> 
> I believe it's ready to be merged, unless I've missed something?

Has slipped my radar for a while, sorry.

I browsed over the series 

Can you pro forma send the v9 (with the scheduler maintainers also in
the cover letter's CC) with the changelog, please?

Then I'd ACK and someone (probably me?) can take it in.

Thanks
P.

> 
> Thanks,
> Pierre-Eric
> 
> Le 20/03/2025 à 10:57, Pierre-Eric Pelloux-Prayer a écrit :
> > Hi,
> > 
> > The initial goal of this series was to improve the drm and amdgpu
> > trace events to be able to expose more of the inner workings of
> > the scheduler and drivers to developers via tools.
> > 
> > Then, the series evolved to become focused only on gpu_scheduler.
> > The changes around vblank events will be part of a different
> > series, as well as the amdgpu ones.
> > 
> > Moreover Sima suggested to make some trace events stable uAPI,
> > so tools can rely on them long term.
> > 
> > The first patches extend and cleanup the gpu scheduler events,
> > then add a documentation entry in drm-uapi.rst.
> > 
> > The last 2 patches are new in v8. One is based on a suggestion
> > from Tvrtko and gets rid of drm_sched_job::id. The other is a
> > cleanup of amdgpu trace events to use the fence=%llu:%llu format.
> > 
> > The drm_sched_job patches don't affect gpuvis which has code to
> > parse
> > the gpu_scheduler events but these events are not enabled.
> > 
> > Changes since v7:
> > * uint64_t -> u64
> > * reworked dependencies tracing (Tvrtko)
> > * use common name prefix for all events (Tvrtko)
> > * dropped drm_sched_job::id (Tvrtko)
> > 
> > Useful links:
> > - userspace tool using the updated events:
> > https://gitlab.freedesktop.org/tomstdenis/umr/-/merge_requests/37
> > - v7:
> > https://lists.freedesktop.org/archives/dri-devel/2025-January/488117.html
> > 
> > Pierre-Eric Pelloux-Prayer (10):
> >    drm/debugfs: output client_id in in drm_clients_info
> >    drm/sched: store the drm client_id in drm_sched_fence
> >    drm/sched: add device name to the drm_sched_process_job event
> >    drm/sched: cleanup gpu_scheduler trace events
> >    drm/sched: trace dependencies for gpu jobs
> >    drm/sched: add the drm_client_id to the drm_sched_run/exec_job
> > events
> >    drm/sched: cleanup event names
> >    drm/doc: document some tracepoints as uAPI
> >    drm: get rid of drm_sched_job::id
> >    drm/amdgpu: update trace format to match gpu_scheduler_trace
> > 
> >   Documentation/gpu/drm-uapi.rst                |  19 ++++
> >   drivers/accel/amdxdna/aie2_ctx.c              |   3 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c    |   2 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c        |   3 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c       |   8 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_job.h       |   3 +-
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h     |  32 ++----
> >   drivers/gpu/drm/drm_debugfs.c                 |  10 +-
> >   drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c  |   2 +-
> >   drivers/gpu/drm/imagination/pvr_job.c         |   2 +-
> >   drivers/gpu/drm/imagination/pvr_queue.c       |   5 +-
> >   drivers/gpu/drm/imagination/pvr_queue.h       |   2 +-
> >   drivers/gpu/drm/lima/lima_gem.c               |   2 +-
> >   drivers/gpu/drm/lima/lima_sched.c             |   6 +-
> >   drivers/gpu/drm/lima/lima_sched.h             |   3 +-
> >   drivers/gpu/drm/msm/msm_gem_submit.c          |   8 +-
> >   drivers/gpu/drm/nouveau/nouveau_sched.c       |   3 +-
> >   drivers/gpu/drm/panfrost/panfrost_drv.c       |   2 +-
> >   drivers/gpu/drm/panthor/panthor_drv.c         |   3 +-
> >   drivers/gpu/drm/panthor/panthor_mmu.c         |   2 +-
> >   drivers/gpu/drm/panthor/panthor_sched.c       |   5 +-
> >   drivers/gpu/drm/panthor/panthor_sched.h       |   3 +-
> >   .../gpu/drm/scheduler/gpu_scheduler_trace.h   | 103
> > +++++++++++++-----
> >   drivers/gpu/drm/scheduler/sched_entity.c      |  16 ++-
> >   drivers/gpu/drm/scheduler/sched_fence.c       |   4 +-
> >   drivers/gpu/drm/scheduler/sched_internal.h    |   2 +-
> >   drivers/gpu/drm/scheduler/sched_main.c        |  11 +-
> >   drivers/gpu/drm/v3d/v3d_submit.c              |   2 +-
> >   drivers/gpu/drm/xe/xe_sched_job.c             |   3 +-
> >   include/drm/gpu_scheduler.h                   |  13 ++-
> >   30 files changed, 186 insertions(+), 96 deletions(-)
> >