Re: [PATCH v9 5/5] rust: Add OwnableRefCounted and SimpleOwnableRefCounted

From: Andreas Hindborg
Date: Wed Apr 09 2025 - 06:19:14 EST


"Oliver Mangold" <oliver.mangold@xxxxx> writes:

> Types implementing one of these traits can safely convert between an
> ARef<T> and an Owned<T>.
>
> This is useful for types which generally are access through an ARef
> but have methods which can only safely called when the reference is unique,
> like e.g. `block::mq::Request::end_ok()`.

You have a few typos here

This is useful for types which generally are *accessed* through an ARef
but have methods which can only *be* safely called when the reference is
unique, like e.g. `block::mq::Request::end_ok()`.

>
> Signed-off-by: Oliver Mangold <oliver.mangold@xxxxx>


Reviewed-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>


Best regards,
Andreas Hindborg