Re: [PATCH v1 1/1] x86/early_printk: Use 'mmio32' for consistency

From: Ingo Molnar
Date: Wed Apr 09 2025 - 06:23:27 EST



* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> First of all, using 'mmio' prevents proper implementation of 8-bit accessors.
> Second, it's simply inconsistent with uart8250 set of options. Rename it to
> 'mmio32'. While at it, remove rather misleading comment in the documentation.
> From now on mmio32 is self-explanatory and pciserial supports not only 32-bit
> MMIO accessors.
>
> Fixes: 3181424aeac2 ("x86/early_printk: Add support for MMIO-based UARTs")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Documentation/admin-guide/kernel-parameters.txt | 5 +----
> arch/x86/kernel/early_printk.c | 6 +++---
> 2 files changed, 4 insertions(+), 7 deletions(-)

Thank you for taking care of this, I've queued these fixes in tip:x86/urgent.

Ingo