Re: [PATCH v1 1/1] x86/early_printk: Fix comment for "pciserial" case
From: Ingo Molnar
Date: Wed Apr 09 2025 - 06:28:49 EST
* Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> The comment seem contains the copy'n'paste error when mentioning "serial"
> instead of "pciserial" (with double quotes). Fix this. With that, move
> it upper, so we don't calculate buf twice.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> arch/x86/kernel/early_printk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
> index dc053641698c..4a9ba7cb7e5a 100644
> --- a/arch/x86/kernel/early_printk.c
> +++ b/arch/x86/kernel/early_printk.c
> @@ -442,9 +442,9 @@ static int __init setup_early_printk(char *buf)
> }
> #ifdef CONFIG_PCI
> if (!strncmp(buf, "pciserial", 9)) {
> - early_pci_serial_init(buf + 9);
> + buf += 9; /* Keep from match the above "pciserial" */
> + early_pci_serial_init(buf);
> early_console_register(&early_serial_console, keep);
> - buf += 9; /* Keep from match the above "serial" */
Note that I merged this into the other fix, in part because the title
isn't accurate anymore, this patch isn't purely fixing the comment.
Thanks,
Ingo