Re: [PATCH net-next v4 05/11] net: ti: prueth: Adds ethtool support for ICSSM PRUETH Driver

[Parvathi Pudi]

Hi,

>> > +#define PRUETH_MODULE_VERSION "0.2"
>> 
>> > +static void icssm_emac_get_drvinfo(struct net_device *ndev,
>> > +				   struct ethtool_drvinfo *info)
>> > +{
>> > +	strscpy(info->driver, PRUETH_MODULE_DESCRIPTION, sizeof(info-
>> >driver));
>> > +	strscpy(info->version, PRUETH_MODULE_VERSION, sizeof(info->version));
>> 
>> Driver version numbers are pointless, they never change, but the
>> kernel is changing all the time. Leave version blank, and the core
>> will fill in the kernel version, which is useful.
>> 
>>      Andrew
> 
> It is also a long standing policy that in-tree drivers should not have versions
> separate from the kernel version.
> 

Ok. We will leave the version field blank as suggested by Andrew and cleanup version
will be resubmitted shortly.


Thanks and Regards,
Parvathi.