Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support
From: Kory Maincent
Date: Wed Apr 09 2025 - 08:40:52 EST
On Wed, 9 Apr 2025 13:16:12 +0100
"Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:
> On Wed, Apr 09, 2025 at 10:48:58AM +0200, Kory Maincent wrote:
> > On Wed, 9 Apr 2025 09:33:09 +0100
> > "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:
> >
> > > On Wed, Apr 09, 2025 at 10:18:08AM +0200, Kory Maincent wrote:
> [...]
> [...]
> > > [...]
> > > [...]
> > > [...]
> > > [...]
> > > [...]
> [...]
> [...]
> > >
> > > I don't spend much time at the physical location where the hardware that
> > > I need to test your long awaited code is anymore. That means the
> > > opportunities to test it are *rare*.
> > >
> > > So far, each time I've tested your code, it's been broken. This really
> > > doesn't help.
> > >
> > > If you want me to do anything more in a timely manner, like test fixes,
> > > you need to get them to me by the end of this week, otherwise I won't
> > > again be able to test them for a while.
> >
> > You could try again with Vlad patch adding support to ndo_hwtstamp_get/set
> > to the mvpp2 drivers.
> > https://github.com/vladimiroltean/linux/commit/5bde95816f19cf2872367ecdbef1efe476e4f833
> >
>
> Well, I'm not sure PTP is working correctly.
>
> On one machine (SolidRun Hummingboard 2), I'm running ptpd v2:
...
> So we can see that ptpdv2 is responding to the delay requests, but it
> seems that ptp4l doesn't see them, but it is seeing the other messages
> from the HB2 running in master mode. I don't have time to investigate
> any further until later today, and then again not until tomorrow
> evening.
Ok, thanks for the tests and these information.
Did you run ptp4l with this patch applied and did you switch to Marvell PHY PTP
source?
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com