Re: [PATCH] s390/boot: replace strncpy() with strscpy()

[Heiko Carstens]

On Thu, Apr 03, 2025 at 02:44:34AM +0330, Amir Mohammad Jahangirzad wrote:
> From: "Amir Mohammad Jahangirzad" <a.jahangirzad@xxxxxxxxx>
> 
> strncpy() is deprecated for use on NUL-terminated destination strings
> as it doesn't guarantee NUL-termination when the source string length
> exceeds the destination buffer size. strscpy() is a safer alternative
> as it always NUL-terminates the destination and returns the number of
> characters copied (excluding the NUL).
> 
> Replace strncpy() with strscpy() for copying the bootdebug_filter value,
> using sizeof(bootdebug_filter) rather than sizeof()-1 since strscpy()
> takes the full buffer size as parameter.
> 
> 
> Link: https://github.com/KSPP/linux/issues/90
> Signed-off-by: Amir Mohammad Jahangirzad <a.jahangirzad@xxxxxxxxx>
> ---
>  arch/s390/boot/ipl_parm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You could have at least compile tested this before sending.