Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB

[Richard Fitzgerald]

On 09/04/2025 3:24 pm, Mark Brown wrote:
> On Wed, Apr 09, 2025 at 11:45:44AM +0100, Richard Fitzgerald wrote:
> > Depend on SND_SOC_CS_AMP_LIB instead of selecting it.
> >
> > KUNIT_ALL_TESTS should only build tests for components that are
> > already being built, it should not cause other stuff to be added
> > to the build.
>
> >   config SND_SOC_CS_AMP_LIB_TEST
> > -	tristate "KUnit test for Cirrus Logic cs-amp-lib"
> > -	depends on KUNIT
> > +	tristate "KUnit test for Cirrus Logic cs-amp-lib" if !KUNIT_ALL_TESTS
> > +	depends on SND_SOC_CS_AMP_LIB && KUNIT
> >   	default KUNIT_ALL_TESTS
> > -	select SND_SOC_CS_AMP_LIB
> >   	help
> >   	  This builds KUnit tests for the Cirrus Logic common
> >   	  amplifier library.
>
> This by itself results in the Cirrus tests being removed from a kunit
> --alltests run which is a regression in coverage.  I'd expect to see
> some corresponding updates in the KUnit all_tests.config to keep them
> enabled.

That's the defined behaviour of KUNIT_ALL_TESTS. It shouldn't have been
running as part of an alltests if nothing had selected it. That seems to
make people angry. Probably the same people who would complain if there
was a bug in the code that they didn't want to test.