Re: [PATCH net-next] net: batman-adv: constify and move broadcast addr definition

From: Matthias Schiffer
Date: Wed Apr 09 2025 - 11:49:40 EST


On 09/04/2025 10:10, Sven Eckelmann wrote:
On Tuesday, 8 April 2025 17:53:36 CEST Matthias Schiffer wrote:
+ const u8 broadcast_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};

Should most likely be "static const u8 ..."

(checkpatch STATIC_CONST_CHAR_ARRAY)

Kind regards,
Sven

Thanks, will send a v2. The checkpatch check only looks for strings, not arrays defined with { }, so it didn't trigger for me.

Best,
Matthias

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature