Re: [PATCH net-next] cxgb4: fix memory leak in cxgb4_init_ethtool_filters() error path

[Markus Elfring]

…
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> @@ -2270,6 +2270,7 @@ int cxgb4_init_ethtool_filters(struct adapter *adap)
>  		eth_filter->port[i].bmap = bitmap_zalloc(nentries, GFP_KERNEL);
>  		if (!eth_filter->port[i].bmap) {
>  			ret = -ENOMEM;
> +			kvfree(eth_filter->port[i].loc_array);
>  			goto free_eth_finfo;
>  		}
>  	}

How do you think about to move the shown error code assignment behind the mentioned label
(so that another bit of duplicate source code could be avoided)?

Regards,
Markus