Re: [PATCH v2 0/2] drm/ci: Add devicetree validation and KUnit tests

[Helen Koike]

Hi Vignesh,

Thank you for your patch.

On 09/04/2025 03:15, Vignesh Raman wrote:
> Add jobs to validate devicetrees and run KUnit tests.
>
> Pipeline link,
> https://gitlab.freedesktop.org/vigneshraman/linux/-/pipelines/1400550

I see the checks are in the same stage as build, does it make sense to 
create another stage? Similar to what was proposed on kci-gitlab?

Also, I don't think it make sense for kunit to be in the build stage. 
Maybe in software-driver? Since kunit runs on a qemu.

Helen

> Link to v1,
> https://lore.kernel.org/all/20250327160117.945165-1-vignesh.raman@xxxxxxxxxxxxx/
>
> Vignesh Raman (2):
>    drm/ci: Add jobs to validate devicetrees
>    drm/ci: Add jobs to run KUnit tests
>
>   drivers/gpu/drm/ci/check-devicetrees.yml | 43 ++++++++++++++++++++++++
>   drivers/gpu/drm/ci/dt-binding-check.sh   | 16 +++++++++
>   drivers/gpu/drm/ci/dtbs-check.sh         | 19 +++++++++++
>   drivers/gpu/drm/ci/gitlab-ci.yml         |  2 ++
>   drivers/gpu/drm/ci/kunit.sh              | 11 ++++++
>   drivers/gpu/drm/ci/kunit.yml             | 32 ++++++++++++++++++
>   6 files changed, 123 insertions(+)
>   create mode 100644 drivers/gpu/drm/ci/check-devicetrees.yml
>   create mode 100755 drivers/gpu/drm/ci/dt-binding-check.sh
>   create mode 100755 drivers/gpu/drm/ci/dtbs-check.sh
>   create mode 100755 drivers/gpu/drm/ci/kunit.sh
>   create mode 100644 drivers/gpu/drm/ci/kunit.yml