Re: commit 7b025f3f85ed causes NULL pointer dereference

[Borislav Petkov]

On Tue, Apr 08, 2025 at 10:46:12PM +0200, Thomas Gleixner wrote:
> diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c
> index 4027abcafe7a..77cc27e45b66 100644
> --- a/drivers/pci/msi/msi.c
> +++ b/drivers/pci/msi/msi.c
> @@ -680,8 +680,8 @@ static int __msix_setup_interrupts(struct pci_dev *__dev, struct msix_entry *ent
>  	if (ret)
>  		return ret;
>  
> -	retain_ptr(dev);
>  	msix_update_entries(dev, entries);
> +	retain_ptr(dev);
>  	return 0;

Tested-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>

Fixes my machine too.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette