Re: [PATCH v4] octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer()

From: Simon Horman
Date: Wed Apr 09 2025 - 15:20:57 EST


On Tue, Apr 08, 2025 at 11:26:02AM +0800, Wentao Liang wrote:
> The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer()
> for each queue in a for loop without checking for any errors.
>
> Check the return value of the cn10k_map_unmap_rq_policer() function during
> each loop, and report a warning if the function fails.
>
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
> ---
> v4: Add brackets for loop
> v3: Add failed queue number and error code to log.
> v2: Fix error code

Thanks for the updates.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>