Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations

[Konrad Dybcio]

On 3/18/25 7:49 AM, Manikanta Mylavarapu wrote:
> Update the bias configuration for UART1 TX and RX pins to ensure correct
> settings for RDP466.
> 
> Additionally, move the UART1 GPIO configurations from the common .dtsi
> file to the RDP-specific .dts files to account for differing bias
> configurations across RDPs of IPQ5424.
> 
> Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@xxxxxxxxxxx>
> ---
> Changes in V2:
> 	- Consolidated uart1_tx_state and uart1_rx_state nodes into a
> 	  single qup_uart1_default_state node, which includes the
> 	  configuration for both UART1 TX and RX pins.
> 	- Inserted a blank line before the status property in the UART1
> 	  node.
> 	- Fixed review comments from Kathiravan Thirumoorthy.
> 
>  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
>  arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> index b9752e8d579e..f0cba6b2be70 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> @@ -102,6 +102,22 @@ &ssphy_0 {
>  };
>  
>  &tlmm {
> +	qup_uart1_default_state: qup-uart1-default-state {
> +		uart1-tx-pins {
> +			pins = "gpio44";
> +			function = "uart1";
> +			drive-strength = <8>;
> +			bias-pull-down;

Pull*down* on TX? Are there noise issues or similar?

Konrad