Re: [PATCH net-next] af_unix: Remove unix_unhash()

From: Kuniyuki Iwashima
Date: Wed Apr 09 2025 - 16:23:00 EST


From: Michal Luczaj <mhal@xxxxxxx>
Date: Wed, 09 Apr 2025 14:50:58 +0200
> Dummy unix_unhash() was introduced for sockmap in commit 94531cfcbe79
> ("af_unix: Add unix_stream_proto for sockmap"), but there's no need to
> implement it anymore.
>
> ->unhash() is only called conditionally: in unix_shutdown() since commit
> d359902d5c35 ("af_unix: Fix NULL pointer bug in unix_shutdown"), and in BPF
> proto's sock_map_unhash() since commit 5b4a79ba65a1 ("bpf, sockmap: Don't
> let sock_map_{close,destroy,unhash} call itself").
>
> Remove it.
>
> Signed-off-by: Michal Luczaj <mhal@xxxxxxx>

Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>