Re: [PATCH] gcc-plugins: Remove SANCOV plugin
From: Kees Cook
Date: Wed Apr 09 2025 - 16:23:43 EST
On Wed, Apr 09, 2025 at 09:28:22PM +0200, Arnd Bergmann wrote:
> On Wed, Apr 9, 2025, at 18:19, Kees Cook wrote:
> > On Wed, Apr 09, 2025 at 06:16:58PM +0200, Arnd Bergmann wrote:
> >> On Wed, Apr 9, 2025, at 18:02, Kees Cook wrote:
> >>
> >> > config KCOV
> >> > bool "Code coverage for fuzzing"
> >> > depends on ARCH_HAS_KCOV
> >> > - depends on CC_HAS_SANCOV_TRACE_PC || GCC_PLUGINS
> >> > + depends on CC_HAS_SANCOV_TRACE_PC
> >>
> >> So this dependency would also disappear. I think either way is fine.
> >>
> >> The rest of the patch is again identical to my version.
> >
> > Ah! How about you keep the patch as part of your gcc-8.1 clean up, then?
> > That seems more clear, etc.
>
> Sure, I can probably keep that all in a branch of the asm-generic
> tree, or alternatively send it through the kbuild tree.
>
> Shall I include the patch to remove the structleak plugin as well?
Sorry, I misread, *stackleak* needs to stay. structleak can go. I'll
carry that.
--
Kees Cook