Re: [PATCH 6.1 000/205] 6.1.134-rc2 review

[Greg KH]

On Wed, Apr 09, 2025 at 06:10:34PM +0200, Miguel Ojeda wrote:
> On Wed, 09 Apr 2025 14:02:32 +0200 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > This is the start of the stable review cycle for the 6.1.134 release.
> > There are 205 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Fri, 11 Apr 2025 11:58:02 +0000.
> > Anything received after that time might be too late.
> 
> For 6.1.y and 6.6.y, Rust fails to build with:
> 
>      error[E0432]: unresolved import `crate::ffi`
>       --> rust/kernel/print.rs:10:5
>        |
>     10 |     ffi::{c_char, c_void},
>        |     ^^^
>        |     |
>        |     unresolved import
>        |     help: a similar path exists: `core::ffi`
> 
> In 6.1.y, C `char` and `core::ffi::c_char` are both signed. So the only issue is
> the `const` -- we can keep using the `core::ffi::c_char` type.
> 
> In 6.6.y, C `char` changed to unsigned, but `core::ffi::c_char` is signed.
> 
> Either way, for both branches, I would recommend dropping the patch -- it is not
> critical, and we can always send it later.
> 
> Thus, for 6.1.y we could just drop the `rust/kernel/print.rs` changes. And for
> 6.6.y we would need something like:

I've dropped this from both queues now, thanks for checking.  Turns out
I'm not test-building rust in these stable releases, nice catch.

If you want this in 6.6.y, can you resubmit it with the suggested
changes that you had in this email?

thanks,

greg k-h