Re: [PATCH v6 3/6] clk: spacemit: Add clock support for SpacemiT K1 SoC

[Alex Elder]

On 4/9/25 7:57 PM, Inochi Amaoto wrote:
> > > > > diff --git a/drivers/clk/spacemit/Kconfig b/drivers/clk/spacemit/Kconfig
> > > > > new file mode 100644
> > > > > index 000000000000..4c4df845b3cb
> > > > > --- /dev/null
> > > > > +++ b/drivers/clk/spacemit/Kconfig
> > > > > @@ -0,0 +1,18 @@
> > > > > +# SPDX-License-Identifier: GPL-2.0-only
> > > > > +
> > > > > +config SPACEMIT_CCU
> > > > > +	tristate "Clock support for SpacemiT SoCs"
> > > > I don't know the answer to this, but...  Should this be a Boolean
> > > > rather than tristate?  Can a SpacemiT K1 SoC function without the
> > > > clock driver built in to the kernel?
> > > I agree to make it a Boolean, we've already made pinctrl driver Boolean
> > > and pinctrl depend on clk, besides, the SoC is unlikely functional
> > > without clock built in as it's such critical..
> > I disagree. The kernel is only for spacemit only, and the pinctrl
> Sorry for a mistake, this first "only" should be "not".

This is a general problem.  You can't make a bootable
SpacemiT kernel unless you define this as built-in (at
least, that's what Yixun is saying).  But we'd really
rather *only* build it in to the kernel for SpacemiT
builds.  You clearly want to minimize what must be
built in, but what if this is indeed required?  What
goes in defconfig?

					-Alex

> > should also be a module. It is the builder's right to decide whether
> > the driver is builtin or a module. In this view, you should always
> > allow the driver to be built as a module if possible.
> >
> > Regards,
> > Inochi