RE: [PATCH net-next v3 2/2] net: stmmac: dwxgmac2: Add support for HW-accelerated VLAN stripping
From: Ng, Boon Khai
Date: Wed Apr 09 2025 - 22:19:56 EST
> >
> > While the logic for handling Tunneled Frame and Non-Tunneled Frame is
> > not yet implemented in the
> > dwxgmac2_wrback_get_rx_vlan_tci() function, I believe it is prudent to
> > maintain separate functions within their respective descriptor driver
> > files, (dwxgmac2_descs.c and dwmac4_descs.c)
>
> Please add a comment, or describe this in the commit message.
>
> Andrew
Hi Adrew,
Thank you for your feedback, sure, I will include the description in the
commit message on v4.
Regarding the overall changes, I believe they effectively consolidated
while maintaining the necessary separation for descriptor function.
Please let me know if there are any additional areas you would like me
to address or further suggestion of improvement.
Thanks you for your guidance and support.
Regards,
Boon Khai