Re: [PATCH] iommu/vt-d: Remove an unnecessary call set_dma_ops()

[Baolu Lu]

On 4/9/25 23:44, Petr Tesařík wrote:
> On Thu,  3 Apr 2025 18:56:05 +0200
> Petr Tesarik<ptesarik@xxxxxxxx> wrote:
>
> > Do not touch per-device DMA ops when the driver has been converted to use
> > the dma-iommu API.
> >
> > Fixes: c588072bba6b ("iommu/vt-d: Convert intel iommu driver to the iommu ops")
> > Signed-off-by: Petr Tesarik<ptesarik@xxxxxxxx>
> Does anyone agree? Or see any issues?

This change looks good to me. The iommu driver should not call
set_dma_ops() anyway. I will queue this for v6.15-rc.

I ever wondered whether we could clean up dev->dma_iommu when the device
is released by the iommu core. But, iommu_release_device() is only
called in the device removal path, so keeping dev->dma_iommu set doesn't
impose any functional impact AFAICS.

Thanks,
baolu