Re: [PATCH v4 03/13] media: pci: cx18-av-vbi: Replace open-coded parity calculation with parity_odd()

[Arend Van Spriel]

On April 10, 2025 12:06:52 AM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:

> On Wed, 2025-04-09 at 20:43 +0200, Arend van Spriel wrote:
> > This is orthogonal to the change to parity_odd() though. More specific
> > to the new parity_odd() you can now do following as parity_odd()
> > argument is u64:
> >
> > err = !parity_odd(*(u16 *)p);
>
> Can it though? Need to be careful with alignment with that, I'd think.

My bad. You are absolutely right.

Gr. AvS
>