Re: [PATCH net-next v2 03/13] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

From: David Howells
Date: Thu Apr 10 2025 - 02:49:41 EST


Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> > + __releases(&rx->sk.sk_lock.slock)
>
> sparse still complains (or maybe in fact it complains because it sees
> the annotation?):
>
> net/rxrpc/oob.c:173:12: warning: context imbalance in 'rxrpc_respond_to_oob' - wrong count at exit
> net/rxrpc/oob.c:223:5: warning: context imbalance in 'rxrpc_sendmsg_oob' - wrong count at exit
>
> Not a deal breaker, just wanted to mention it.

Yeah. I'm pretty sure I have the releases in all the right place. The
problem might be that *release_sock()* lacks the annotation.

David