Re: [PATCH 05/28] mfd: zl3073x: Add components versions register defs

[Krzysztof Kozlowski]

On 09/04/2025 08:44, Ivan Vecera wrote:
> On 07. 04. 25 11:09 odp., Andrew Lunn wrote:
>> On Mon, Apr 07, 2025 at 07:28:32PM +0200, Ivan Vecera wrote:
>>> Add register definitions for components versions and report them
>>> during probe.
>>>
>>> Reviewed-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
>>> Signed-off-by: Ivan Vecera <ivecera@xxxxxxxxxx>
>>> ---
>>>   drivers/mfd/zl3073x-core.c | 35 +++++++++++++++++++++++++++++++++++
>>>   1 file changed, 35 insertions(+)
>>>
>>> diff --git a/drivers/mfd/zl3073x-core.c b/drivers/mfd/zl3073x-core.c
>>> index 39d4c8608a740..b3091b00cffa8 100644
>>> --- a/drivers/mfd/zl3073x-core.c
>>> +++ b/drivers/mfd/zl3073x-core.c
>>> @@ -1,10 +1,19 @@
>>>   // SPDX-License-Identifier: GPL-2.0-only
>>>   
>>> +#include <linux/bitfield.h>
>>>   #include <linux/module.h>
>>>   #include <linux/unaligned.h>
>>>   #include <net/devlink.h>
>>>   #include "zl3073x.h"
>>>   
>>> +/*
>>> + * Register Map Page 0, General
>>> + */
>>> +ZL3073X_REG16_DEF(id,			0x0001);
>>> +ZL3073X_REG16_DEF(revision,		0x0003);
>>> +ZL3073X_REG16_DEF(fw_ver,		0x0005);
>>> +ZL3073X_REG32_DEF(custom_config_ver,	0x0007);
>>> +
>>>   /*
>>>    * Regmap ranges
>>>    */
>>> @@ -159,10 +168,36 @@ EXPORT_SYMBOL_NS_GPL(zl3073x_dev_alloc, "ZL3073X");
>>>   
>>>   int zl3073x_dev_init(struct zl3073x_dev *zldev)
>>>   {
>>> +	u16 id, revision, fw_ver;
>>>   	struct devlink *devlink;
>>> +	u32 cfg_ver;
>>> +	int rc;
>>>   
>>>   	devm_mutex_init(zldev->dev, &zldev->lock);
>>>   
>>> +	scoped_guard(zl3073x, zldev) {
>>
>> Why the scoped_guard? The locking scheme you have seems very opaque.
> 
> We are read the HW registers in this block and the access is protected 
> by this device lock. Regmap locking will be disabled in v2 as this is 

Reading ID must be protected by mutex? Why and how?

What is a "device lock"?

> not sufficient.
> 
>>> +		rc = zl3073x_read_id(zldev, &id);
>>> +		if (rc)
>>> +			return rc;
>>> +		rc = zl3073x_read_revision(zldev, &revision);
>>> +		if (rc)
>>> +			return rc;
>>> +		rc = zl3073x_read_fw_ver(zldev, &fw_ver);
>>> +		if (rc)
>>> +			return rc;
>>> +		rc = zl3073x_read_custom_config_ver(zldev, &cfg_ver);
>>> +		if (rc)
>>> +			return rc;
>>
>> Could a parallel operation change the ID? Upgrade the firmware
>> version?
>>
>> 	Andrew
> 
> No, but register access functions require the device lock to be held. 
> See above.

Andrew comments stay valid here. This is weird need of locking and your
explanation is very vague.

BTW, do not send v2 before people respond to your comments in reasonable
time. You just send 28 patchset and expect people to finish review after
one day.

Best regards,
Krzysztof