Re: [PATCH v9 1/7] mfd: Add core driver for Nuvoton NCT6694

[Krzysztof Kozlowski]

On 10/04/2025 09:52, Lee Jones wrote:
> On Thu, 10 Apr 2025, Krzysztof Kozlowski wrote:
> 
>> On 09/04/2025 10:27, a0282524688@xxxxxxxxx wrote:
>>> +
>>> +static int nct6694_response_err_handling(struct nct6694 *nct6694,
>>> +					 unsigned char err_status)
>>> +{
>>> +	switch (err_status) {
>>> +	case NCT6694_NO_ERROR:
>>> +		return 0;
>>> +	case NCT6694_NOT_SUPPORT_ERROR:
>>> +		dev_err(nct6694->dev, "Command is not supported!\n");
>>> +		break;
>>> +	case NCT6694_NO_RESPONSE_ERROR:
>>> +		dev_warn(nct6694->dev, "Command received no response!\n");
>>> +		break;
>>> +	case NCT6694_TIMEOUT_ERROR:
>>> +		dev_warn(nct6694->dev, "Command timed out!\n");
>>> +		break;
>>> +	case NCT6694_PENDING:
>>> +		dev_err(nct6694->dev, "Command is pending!\n");
>>> +		break;
>>> +	default:
>>> +		return -EINVAL;
>>> +	}
>>> +
>>> +	return -EIO;
>>> +}
>>> +
>>
>> Missing Kconfig. Exported functions are supposed to have it.
>           -------
> 
> KernelDoc


Yes, thank you. -ENOCOFFEE


Best regards,
Krzysztof