Re: [PATCH v6 01/12] dt-bindings: mfd: gpio: Add MAX7360

[Mathieu Dubois-Briand]

On Wed Apr 9, 2025 at 10:58 PM CEST, Dmitry Torokhov wrote:
> Hi Mathieu,

Hi Dmitry,

>
> On Wed, Apr 09, 2025 at 04:55:48PM +0200, Mathieu Dubois-Briand wrote:
>> Add device tree bindings for Maxim Integrated MAX7360 device with
>> support for keypad, rotary, gpios and pwm functionalities.
>> 
>> +
>> +    i2c {
>> +      #address-cells = <1>;
>> +      #size-cells = <0>;
>> +
>> +      io-expander@38 {
>> +        compatible = "maxim,max7360";
>> +        reg = <0x38>;
>> +
>> +        interrupt-parent = <&gpio1>;
>> +        interrupts = <23 IRQ_TYPE_LEVEL_LOW>,
>> +                     <24 IRQ_TYPE_LEVEL_LOW>;
>> +        interrupt-names = "inti", "intk";
>> +
>> +        keypad,num-rows = <8>;
>> +        keypad,num-columns = <4>;
>> +        linux,keymap = <
>> +          MATRIX_KEY(0x00, 0x00, KEY_F5)
>> +          MATRIX_KEY(0x01, 0x00, KEY_F4)
>> +          MATRIX_KEY(0x02, 0x01, KEY_F6)
>> +          >;
>> +        keypad-debounce-delay-ms = <10>;
>> +        autorepeat;
>> +
>> +        rotary-debounce-delay-ms = <2>;
>> +        linux,axis = <0>; /* REL_X */
>
> Probably this has been already discussed, but shouldn't keyboard and
> rotary encoder be represented as sub-nodes here, similar to how GPIO
> block is represented?
>
> Thanks.

Yes, this has been discussed on v1 and I was asked to remove most of the
subnodes.

https://lore.kernel.org/lkml/58c80c2a-2532-4bc5-9c9f-52480b3af52a@xxxxxxxxxx/

Thanks for your review.

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com