Re: [PATCH] KVM: arm64: nv: Forward hvc traps if originated from nested VM

From: Ganapatrao Kulkarni
Date: Thu Apr 10 2025 - 06:27:09 EST




On 10-04-2025 12:49 pm, Marc Zyngier wrote:
On Thu, 10 Apr 2025 08:07:43 +0100,
Ganapatrao Kulkarni <gankulkarni@xxxxxxxxxxxxxxxxxxxxxx> wrote:

It was discovered while trying selftest(smccc_filter) that the
hvc trap is getting forwarded to guest hypervisor even if it is
originated from itself.

HVC traps from guest hypervisor should be handled by the host
hypervisor and traps originating from nested VM should be
forwarded. Adding check to forward only if the hvc is trapped
from the nested VM.

I disagree. HVC from EL2 must be routed to the same EL2. HVC from EL1
must be routed to the EL2 controlling EL1.

Thanks, Understood, In NV case, hvc has to be forwarded to L1 irrespective of it origin (L1 or L2). Need to add hvc handler in the smccc_filter.c for the vm (when run as L1), so that it is handled and returns with required args set.


--
Thanks,
Ganapat/GK