Re: [PATCH v2] platform/x86: portwell-ec: Add GPIO and WDT driver for Portwell EC

[jesse huang]

Hi Bartosz,

Thank you for the review!

On 09/04/2025 7:46 PM, Bartosz Golaszewski wrote:
> On Wed, Apr 9, 2025 at 1:26 PM Yen-Chi Huang
> <jesse.huang@xxxxxxxxxxxxxxx> wrote:

>> +static struct gpio_chip pwec_gpio_chip = {
>> +       .label = "portwell-ec-gpio",
>> +       .get_direction = pwec_gpio_get_direction,
>> +       .direction_input = pwec_gpio_direction_input,
>> +       .direction_output = pwec_gpio_direction_output,
>> +       .get = pwec_gpio_get,
>> +       .set = pwec_gpio_set,
> 
> Please use the set_rv() variant, set() is deprecated as of v6.15-rc1.
> 

Will update to `.set_rv` callback in v3.

>> +static int __init pwec_init(void)
>> +{
> 
> I'm not an expert in x86 platform drivers but shouldn't this be
> implemented as an actual platform driver, not a hand-coded
> quasi-driver?
> 
> Bart
> 

Will update the driver to use `platform_driver` in v3.

Best regards,  
Yen-Chi