Re: [PATCH v2 2/3] rust: dma: convert the read/write macros to return Result
From: Danilo Krummrich
Date: Thu Apr 10 2025 - 07:22:20 EST
On Thu, Apr 10, 2025 at 11:58:17AM +0300, Abdiel Janulgue wrote:
> We could do better here by having the macros return `Result`,
> so that we don't have to wrap these calls in a closure for
> validation which is confusing.
>
> Co-developed-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> Signed-off-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> Suggested-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
> Link: https://lore.kernel.org/rust-for-linux/87h63qhz4q.fsf@xxxxxxxxxx/
> Reviewed-by: Andreas Hindborg <a.hindborg@xxxxxxxxxx>
I think you can drop this and the Suggested-by tag, since Andreas is also a
co-author.