Re: [PATCH] drm/bridge: dw-hdmi: Avoid including uapi headers

From: Heiko Stübner
Date: Thu Apr 10 2025 - 08:54:54 EST


Hi Andy,

Am Freitag, 14. März 2025, 08:57:47 Mitteleuropäische Sommerzeit schrieb Andy Yan:
> From: Andy Yan <andy.yan@xxxxxxxxxxxxxx>
>
> It is not recommended for drivers to include UAPI header
> directly.
>
> Signed-off-by: Andy Yan <andy.yan@xxxxxxxxxxxxxx>

Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>


But looking at
scripts/get_maintainer.pl -f drivers/gpu/drm/bridge
it seems like your cc-list is missing bridge people:

Andrzej Hajda <andrzej.hajda@xxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Neil Armstrong <neil.armstrong@xxxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Robert Foss <rfoss@xxxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jonas Karlman <jonas@xxxxxxxxx> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)
Jernej Skrabec <jernej.skrabec@xxxxxxxxx> (reviewer:DRM DRIVERS FOR BRIDGE CHIPS)


> ---
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 0890add5f707..306e09a24a1c 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -22,8 +22,8 @@
>
> #include <media/cec-notifier.h>
>
> -#include <uapi/linux/media-bus-format.h>
> -#include <uapi/linux/videodev2.h>
> +#include <linux/media-bus-format.h>
> +#include <linux/videodev2.h>
>
> #include <drm/bridge/dw_hdmi.h>
> #include <drm/display/drm_hdmi_helper.h>
>