Re: [PATCH v7 3/3] mm/mempolicy: Support memory hotplug in weighted interleave

[David Hildenbrand]

On 10.04.25 15:25, Honggyu Kim wrote:
> Hi David,
>
> On 4/9/2025 8:52 PM, David Hildenbrand wrote:
> > On 09.04.25 13:39, Honggyu Kim wrote:
> > > Hi David,
> > >
> > > On 4/9/2025 6:05 PM, David Hildenbrand wrote:
> > > > On 08.04.25 09:32, Rakie Kim wrote:
> [...snip...]
> > > > > Signed-off-by: Rakie Kim <rakie.kim@xxxxxx>
> > > > > Signed-off-by: Honggyu Kim <honggyu.kim@xxxxxx>
> > > > > Signed-off-by: Yunjeong Mun <yunjeong.mun@xxxxxx>
> > > >
> > > > Why are the other SOF in there? Are there Co-developed-by missing?
> > >
> > > I initially found the problem and fixed it with my internal implementation but
> > > Rakie also had his idea so he started working on it.  His initial implementation
> > > has almost been similar to mine.
> > >
> > > I thought Signed-off-by is a way to express the patch series contains our
> > > contribution, but if you think it's unusual, then I can add this.
> >
> > Please see Documentation/process/submitting-patches.rst,
>
> Thanks for the info.
>
> > and note that these are not "patch delivery" SOB.
> >
> > "
> > The Signed-off-by: tag indicates that the signer was involved in the
> > development of the patch, or that he/she was in the patch's delivery path.
>
> Yunjeong and I have been involved in finding the problem and also concluded this
> issue is related to hotplug together with our initial implementations before
> this patch.  So I guess it is the former case.

IIRC, usually we use Co-developed-by + SOB only if there are actual code 
contributions: when you would consider someone a "co-author".

"Co-developed-by: denotes authorship"

For suggestions we use Suggested-by, and for things that popped up 
during a review, it's usually a good idea that reviewers supply a 
Reviewed-by at the end.


So I guess Co-developed-by + SOB is appropriate if people consider 
themselves co-authors, in addition  to the main author.

> > "
> >
> > and
> >
> > "
> > Co-developed-by: states that the patch was co-created by multiple developers;
> > it is used to give attribution to co-authors (in addition to the author
> > attributed by the From: tag) when several people work on a single patch.  Since
> > Co-developed-by: denotes authorship, every Co-developed-by: must be immediately
> > followed by a Signed-off-by: of the associated co-author.  Standard sign-off
>
> So the Co-developed-by comes before Signed-off-by.

Yes.

--
Cheers,

David / dhildenb