Re: [EXTERNAL] Re: [PATCH rdma-next 3/3] RDMA/mana_ib: Add support of 4M, 1G, and 2G pages

[Leon Romanovsky]

On Thu, Apr 10, 2025 at 01:38:39PM +0000, Konstantin Taranov wrote:
> > 
> > >  enum gdma_page_type {
> > >  	GDMA_PAGE_TYPE_4K,
> > > +	GDMA_PAGE_SIZE_8K,
> > > +	GDMA_PAGE_SIZE_16K,
> > > +	GDMA_PAGE_SIZE_32K,
> > > +	GDMA_PAGE_SIZE_64K,
> > > +	GDMA_PAGE_SIZE_128K,
> > > +	GDMA_PAGE_SIZE_256K,
> > > +	GDMA_PAGE_SIZE_512K,
> > > +	GDMA_PAGE_SIZE_1M,
> > > +	GDMA_PAGE_SIZE_2M,
> > > +	/* Only when
> > GDMA_DRV_CAP_FLAG_1_GDMA_PAGES_4MB_1GB_2GB is set */
> > > +	GDMA_PAGE_SIZE_4M,
> > > +	GDMA_PAGE_SIZE_1G = 18,
> > > +	GDMA_PAGE_SIZE_2G
> > 
> > Where are all these defines used?
> 
> There are not used explicitly in this patch, but they can be used in theory.

Yes, please.

> I can remove unused defines in V2.
> 
> > 
> > Thanks