Re: [PATCH net-next] tcp: drop tcp_v{4,6}_restore_cb

From: Eric Dumazet
Date: Thu Apr 10 2025 - 12:24:49 EST


On Thu, Apr 10, 2025 at 6:16 PM Stanislav Fomichev <sdf@xxxxxxxxxxx> wrote:
>
> Instead of moving and restoring IP[6]CB, reorder tcp_skb_cb
> to alias with inet[6]_skb_parm. Add static asserts to make
> sure tcp_skb_cb fits into skb.cb and that inet[6]_skb_parm is
> at the proper offset.

May I ask : why ?

I think you are simply reverting 971f10eca18 ("tcp: better TCP_SKB_CB
layout to reduce cache line misses")
without any performance measurements.