Re: [PATCH net-next v25 04/23] ovpn: keep carrier always on for MP interfaces

From: Jakub Kicinski
Date: Thu Apr 10 2025 - 23:03:39 EST


On Mon, 07 Apr 2025 21:46:12 +0200 Antonio Quartulli wrote:
> + /* carrier for P2P interfaces is switched on and off when
> + * the peer is added or deleted.
> + *
> + * in case of P2MP interfaces we just keep the carrier always on
> + */
> + if (ovpn->mode == OVPN_MODE_MP)
> + netif_carrier_on(dev);

Any reason why you turn it during open rather than leaving it be before
registration? Now the link is down until first open, then it stays up
even if user closes?