RE: [PATCH] Removing deprecated strncpy()
From: Tung Quang Nguyen
Date: Fri Apr 11 2025 - 01:22:23 EST
>This patch suggests the replacement of strncpy with strscpy as per
>Documentation/process/deprecated.
>The strncpy() fails to guarntee NULL termination, The function adds zero pads
>which isn't really convenient for short strings as it may cause performce issues
>
>strscpy() is a preffered replacement because it overcomes the limitations of
>strncpy mentioned above
>
Please read my comment for your previous patch:
- Add "net-next" to your email subject like this: [PATCH net-next]
- Fix many typos in your changelog: guarntee -> guarantee, performce --> performance, preffered --> preferred
>Compile Tested
>
>Signed-off-by: Kevin Paul Reddy Janagari <kevinpaul468@xxxxxxxxx>
>---
> net/tipc/node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/net/tipc/node.c b/net/tipc/node.c index
>ccf5e427f43e..cb43f2016a70 100644
>--- a/net/tipc/node.c
>+++ b/net/tipc/node.c
>@@ -1581,7 +1581,7 @@ int tipc_node_get_linkname(struct net *net, u32
>bearer_id, u32 addr,
> tipc_node_read_lock(node);
> link = node->links[bearer_id].link;
> if (link) {
>- strncpy(linkname, tipc_link_name(link), len);
>+ strscpy(linkname, tipc_link_name(link), len);
please merge this change into your previous patch. We do not need a separate patch for the same purpose.