RE: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports

From: Faraz Ata
Date: Fri Apr 11 2025 - 02:28:23 EST


Hello Krzysztof

> Subject: Re: [PATCH v2] tty: serial: samsung_tty: support 18 uart ports
>
> On 04/04/2025 15:50, Faraz Ata wrote:
> > Exynos Auto v920 SoC supports up to 18 UART ports.
> > Hence changing the value of UART_NR to 18.
> > ---
>
> How v2, without changelog, is even worse than v1? It goes to wrong
> direction.
>
> Please run scripts/checkpatch.pl and fix reported warnings. After that, run
> also `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some
> warnings can be ignored, especially from --strict run, but the code here looks
> like it needs a fix. Feel free to get in touch if the warning is not clear.
>
>
Thanks for your review and sorry for the noise,
that was not intentional, got posted by mistake, will takecare about it.
Will send another version with change-log.
> ...
> Best regards,
> Krzysztof