Re: [PATCH net-next v5 1/4] net: ethtool: Introduce per-PHY DUMP operations

[Maxime Chevallier]

Hi Jakub,

On Thu, 10 Apr 2025 17:21:55 -0700
Jakub Kicinski <kuba@xxxxxxxxxx> wrote:

> On Thu, 10 Apr 2025 14:33:46 +0200 Maxime Chevallier wrote:
> > ethnl commands that target a phy_device need a DUMP implementation that
> > will fill the reply for every PHY behind a netdev. We therefore need to
> > iterate over the dev->topo to list them.
> > 
> > When multiple PHYs are behind the same netdev, it's also useful to
> > perform DUMP with a filter on a given netdev, to get the capability of
> > every PHY.
> > 
> > Implement dedicated genl ->start(), ->dumpit() and ->done() operations
> > for PHY-targetting command, allowing filtered dumps and using a dump
> > context that keep track of the PHY iteration for multi-message dump.  
> 
> Transient warnings here that the new functions are not used :(
> Would it work to squash the 3rd and 4th patches in?
> Not ideal but better than having a warning.

ah damn yes indeed... meh sorry about that, I'll squash the other
patches in (except for the net/ethtool/phy.c patch). That said are you
more comfortable with this approach ? I was unsure this was what you
were expecting from the previous iteration.

Thanks,

Maxime