Re: [PATCH 1/4] wifi: mwifiex: remove unnecessary queue empty check
From: Francesco Dolcini
Date: Fri Apr 11 2025 - 03:44:01 EST
On Thu, Apr 10, 2025 at 12:28:43PM +0200, Sascha Hauer wrote:
> Since 7bff9c974e1a ("mwifiex: send firmware initialization commands
> synchronously") all initialization commands are sent synchronously which
> means the command queue is empty when mwifiex_sta_init_cmd() returns. No
> need to check for entries in the command code then, so remove the check.
>
> Add a WARN_ON() just in case there is something wrong with the
> reasoning.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Reviewed-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>