Re: [PATCH net-next v2 2/2] net: phy: Add Marvell PHY PTP support

[Kory Maincent]

On Thu, 10 Apr 2025 20:40:12 +0100
"Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:

> On Thu, Apr 10, 2025 at 07:16:47PM +0100, Russell King (Oracle) wrote:
> > On Thu, Apr 10, 2025 at 06:02:05PM +0200, Kory Maincent wrote:  
> > > On Thu, 10 Apr 2025 16:41:06 +0100
> > > "Russell King (Oracle)" <linux@xxxxxxxxxxxxxxx> wrote:

> > > It seems you are still using your Marvell PHY drivers without my change.
> > > PTP L2 was broken on your first patch and I fixed it.
> > > I have the same result without the -2 which mean ptp4l uses UDP IPV4.  
> > 
> > I'm not sure what you're referring to.  
> 
> Okay, turns out to be nothing to do with any fixes in my code or not
> (even though I still don't know what the claimed brokenness you
> refer to actually was.)

If I remember well you need the PTP global config 1 register set to 3 to have
the L2 PTP working.

> It turns out to be that ptpdv2 sends PTP packets using IPv4 UDP *or*
> L2, and was using IPv4 UDP. Adding "ptpengine:transport=ethernet" to
> the ptpdv2 configuration allows ptp4l -2 to then work.

Ack.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com